async_hooks: don't set hook_fields[kTotals] to 0 #19219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
async_hooks
node-test-commit failure looks unrelatednot ok 876 parallel/test-http2-info-headers-errors
---
duration_ms: 0.342
severity: fail
stack: |-
(node:605) ExperimentalWarning: The http2 module is an experimental API.
... |
addaleax
approved these changes
Mar 8, 2018
apapirovski
previously requested changes
Mar 8, 2018
There was a problem hiding this comment.
If we're doing this — which I'm not a fan of because the chained statement is now much harder to read (the first and second operations are different) — then we should be doing this for disable() too.
The subsystem should be updated to async_hooks rather than src.
This commit removes the setting of hook_field[kTotals] to szero in AsyncHook's enable function. As far as I can tell this would not be required if the setting of this field is done with the assignment operator instead of using the addition assignment operator.
danbev
force-pushed
the
async_hooks_kTotals
branch
from
002c636
to
77a9313
Compare
danbev
changed the title
|
@apapirovski I've updated the I know that @addaleax approved this change but I'm getting the feeling that I might be alone in my view regarding that this change is for the better. How about if anyone else chimes in favour of keeping it as it is lets close this. |
|
@danbev Thanks for making the changes. I'm fine with it landing. It's totally possible I'm alone in finding it a bit harder to read :) |
daynin
approved these changes
Mar 8, 2018
jasnell
approved these changes
Mar 8, 2018
|
Landed in ddcc00b. |
danbev
added a commit
that referenced
this pull request
Mar 11, 2018
This commit removes the setting of hook_field[kTotals] to szero in AsyncHook's enable function. As far as I can tell this would not be required if the setting of this field is done with the assignment operator instead of using the addition assignment operator. PR-URL: #19219 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
This commit removes the setting of hook_field[kTotals] to szero in AsyncHook's enable function. As far as I can tell this would not be required if the setting of this field is done with the assignment operator instead of using the addition assignment operator. PR-URL: #19219 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
This commit removes the setting of hook_field[kTotals] to szero in AsyncHook's enable function. As far as I can tell this would not be required if the setting of this field is done with the assignment operator instead of using the addition assignment operator. PR-URL: #19219 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This commit removes the setting of hook_field[kTotals] to szero in AsyncHook's enable function. As far as I can tell this would not be required if the setting of this field is done with the assignment operator instead of using the addition assignment operator. PR-URL: nodejs#19219 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the setting of hook_field[kTotals] to szero in
AsyncHook's enable function.
As far as I can tell this would not be required if the setting of
this field is done with the assignment operator instead of using the
addition assignment operator.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes